Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First batch of outstanding DSTU2 resources #22

Merged
merged 15 commits into from
Aug 30, 2020
Merged

First batch of outstanding DSTU2 resources #22

merged 15 commits into from
Aug 30, 2020

Conversation

mmabey
Copy link
Contributor

@mmabey mmabey commented Aug 26, 2020 •
edited
Loading

Implemented the following resource types, regarding issue #21:

  • DetectedIssue
  • DataElement
  • DeviceComponent
  • DeviceMetric
  • DeviceUseRequest
  • DeviceUseStatement
  • DiagnosticOrder
  • DocumentManifest
  • DocumentReference
  • ElementDefinition (this one is HUGE!!)
  • EligibilityRequest
  • EligibilityResponse
  • EnrollmentRequest

@mmabey mmabey changed the title First batch of outstanding DSTU2 resources, RE #21 First batch of outstanding DSTU2 resources Aug 26, 2020
nazrulworld
nazrulworld reviewed Aug 27, 2020
View reviewed changes
Copy link
Owner

@nazrulworld nazrulworld left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the validator missing for some resources?
for example, there should entry in ´fhirvalidators.py´ detectedIssue_validator, ´ detectedIssuemitigation_validator´

@mmabey
Copy link
Contributor Author

mmabey commented Aug 27, 2020

Ah yes. We realized half way through these commits that we needed to add validators. I must have forgotten to go back and add them to the first ones I did. Sorry about that!

@nazrulworld
Copy link
Owner

Ah yes. We realized half way through these commits that we needed to add validators. I must have forgotten to go back and add them to the first ones I did. Sorry about that!

Ha ha, there is no sorry please, I am really grateful, to your great effort. Thanks a lot.

@nazrulworld nazrulworld merged commit 98e2e33 into nazrulworld:master Aug 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nazrulworld nazrulworld nazrulworld left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmabey @nazrulworld