Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support en dash at consistent-separator #163

Closed
koppor opened this issue Oct 22, 2023 · 4 comments
Closed

Support en dash at consistent-separator #163

koppor opened this issue Oct 22, 2023 · 4 comments
Labels
bug Something isn't working
Milestone

Comments

@koppor
Copy link
Contributor

koppor commented Oct 22, 2023

In https://github.com/JabRef/jabref/blob/v5.11/CHANGELOG.md, I get

1:1  error  Expecting consistent version-date separator \u002d, found [\u2013]  consistent-separator

At #140, I introduced support for \u2013 for date separation.

I think, something is wrong in the "consistent-seaprator" check.

@koppor koppor changed the title Support en dash at Support en dash at consistent-separator Oct 22, 2023
@koppor
Copy link
Contributor Author

koppor commented Nov 8, 2023

I have the same issue with https://github.com/gi-ev/biblatex-lni/blob/4ba4f7fd4448c74bad931d784612c92f6b67b2c6/CHANGELOG.md. It is a blocker for me @charphi. Maybe, debugging with #164 helps.

@charphi
Copy link
Member

charphi commented Nov 8, 2023

Hi @koppor. Sorry to be so late in replying, but I'm back from holiday and the backlog at work is quite overwhelming.
Anyway, I've merged #164 and I will try to debug your problem as soon as possible.

I'm using the following command to quickly check the content of your changelog:

curl https://raw.githubusercontent.com/gi-ev/biblatex-lni/4ba4f7fd4448c74bad931d784612c92f6b67b2c6/CHANGELOG.md | java -jar heylogs-cli/target/heylogs-cli-0.7.2-SNAPSHOT-bin.jar check -

And the result is:

stdin
   1:1   error  Expecting consistent version-date separator \u002d, found [\u002d, \u2013]  consistent-separator
   4:64  error  Expecting HTTPS protocol                                                    https
  32:1   error  Missing ref link                                                            all-h2-contain-a-version

  3 problems

@charphi charphi added the bug Something isn't working label Nov 9, 2023
@charphi charphi added this to the 0.7.2 milestone Nov 9, 2023
@charphi
Copy link
Member

charphi commented Nov 9, 2023

So, the problem comes from the fact that "unreleased" header has a default separator. I've a added a filter to avoid the problem in 2e8f568. Could you check it on your changelogs ?

@koppor
Copy link
Contributor Author

koppor commented Nov 10, 2023

Works great:

2023-11-09 23:57:37 [main] internal.heylogs.GitDiffRule.validate()
DEBUG: Ignoring invalid version at Heading{}
CHANGELOG.md
  1184:1  error  Missing ref link  all-h2-contain-a-version (ignored)

  1 problem

We just ignore that error in our CI 👼 -- https://github.com/JabRef/jabref/blob/934a0c86d880b4b4fa1ddfa7da2e8fb7390cee2e/.github/workflows/tests.yml#L185

@koppor koppor closed this as completed Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants