Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync version.config file with AssemblyInfo.fs with bump.fsx #18

Open
knocte opened this issue Jan 12, 2023 · 1 comment
Open

Sync version.config file with AssemblyInfo.fs with bump.fsx #18

knocte opened this issue Jan 12, 2023 · 1 comment

Comments

@knocte
Copy link
Member

knocte commented Jan 12, 2023

  • Take in account AssemblyInfo.fs is not included in Fsdk.fsproj (it is in Fsdk-legacy.fsproj), by mistake.
  • Ideally bump.fsx should also create the git tag (and advice to push it, like in geewallet).
  • nugetPush of git tag should verify that tag starts with BaseVersion val of version.config.
@knocte
Copy link
Member Author

knocte commented Mar 19, 2023

For the 1st bullet, we gotta take in account nblockchain/geewallet@2edb96e .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant