-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strange null reference exception in Ether code #282
Comments
I've digged a little bit in our Nethereum fork (https://github.com/nblockchain/Nethereum) and so far I think I found that the culprit is actually in JsonRpcSharp, in particular here: Seems that in order to understand the problem better, we would need to first change returnDefaultIfNull param to default to false, and test again to see if we get the exception "Unable to convert the result (null) to type ...". If that is the case, then it means that somehow |
Indeed Enabling debug output showed that response json was:
In other responses, |
So I think this should be handled on geewallet side. But I don't know which exception type to use here to signal invalid response from serever. |
Introduce WeirdNullResponseException type and raise it when response for balance request for Ethereum returns json with "result" field value of `null`. This way server will be marked as faulty instead of crashing the application. Fixes nblockchain#282
Introduce WeirdNullResponseException type and raise it when response for balance request for Ethereum returns json with "result" field value of `null`. This way server will be marked as faulty instead of crashing the application. Fixes nblockchain#282
Introduce WeirdNullResponseException type and raise it when response for balance request for Ethereum returns json with "result" field value of `null`. This way server will be marked as faulty instead of crashing the application. Fixes nblockchain#282
Introduce WeirdNullResponseException type and raise it when response for balance request for Ethereum returns json with "result" field value of `null`. This way server will be marked as faulty instead of crashing the application. Fixes nblockchain#282
Introduce WeirdNullResponseException type and raise it when response for balance request for Ethereum returns json with "result" field value of `null`. This way server will be marked as faulty instead of crashing the application. Fixes nblockchain#282
Introduce AbnormalNullValueInJsonResponseException type and raise it when response for balance request for Ethereum returns json with "result" field value of `null`. This way server will be marked as faulty instead of crashing the application. Fixes nblockchain#282
CI of today started failing with:
https://github.com/nblockchain/geewallet/actions/runs/9815030138
Quoting error:
When running geewallet locally, I got the same problem but with slightly different stacktrace:
Both problems seem to be caused by a
null
value being returned fromweb3.Eth.GetBalance.SendRequestAsync()
method.The text was updated successfully, but these errors were encountered: