Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation: FR - French #6

Open
azarz opened this issue Oct 28, 2018 · 5 comments
Open

Translation: FR - French #6

azarz opened this issue Oct 28, 2018 · 5 comments

Comments

@azarz
Copy link
Contributor

azarz commented Oct 28, 2018

Merged. Close issue?

Diff: https://github.com/azarz/remember/pull/2/files?utf8=%E2%9C%93&diff=split&w=1

Deployment: https://ncase.me/remember/fr

(thx a lot @arnaudgregoire!)

@fititnt
Copy link
Contributor

fititnt commented Oct 28, 2018

I know (a bit) that feel of one language be more verbose than English.

Also I'm a bit curious how thinks like the "How To Remember Anything Forever-ish", the Tony Stark part and "cramming" (for languages that does not have one exactly translation for this) will be used.

@fititnt
Copy link
Contributor

fititnt commented Oct 28, 2018

Since you already done a PR to your branch repo to see the changes, if you want to make http://azarz.github.io/rememer/fr.html available for preview, one way is go to https://github.com/azarz/remember/settings, then set "gh-pages" as the branch like this

captura de tela de 2018-10-28 12-51-01

On the Portuguese translation, I was not able to make any arbitrary branch as github pages source (sadly, only master or gh-pages) so to preview I have one branch like yours and I push the changes also to the gh-pages. This is one additional step to make both the trick of gihub pages and the PR+review to work.

Also, one trick to make be able to see side by side translation (see https://github.com/fititnt/remember/pull/1/files) is that the target branch must already have the original file (your Init french translation with fr.html file), so the diff changes of the PR are only the exactly strings, not the entire file. In theory this github kung fu could be used for reviews later, even people not very familiar with github with just the web interface.

@stellingsimon
Copy link

@fititnt Regarding translating the title "How to...": in the German translation, I resorted to an alternative that is literally translated as "The way to perfect memory, or what not." Maybe that helps :-)

@azarz
Copy link
Contributor Author

azarz commented Oct 29, 2018

@fititnt Thanks a lot, this will be a lot easier for reviewers now ! :)

@fititnt
Copy link
Contributor

fititnt commented Oct 29, 2018

Usage of style="font-size:20px" will be quite massive I think.

On Portuguese, the default size at the end maybe will be like 22~23px, but I applied a hotfix with at ramon-mendes@75f6e66 so the preview https://fititnt.github.io/remember/pt.html at least would allow reviews see the texts and give extra time to go pixel perfect. I think I will leave more for the end of the translation to define text sizes, but maybe you and others with languages more verboses than English would love to try add something like this after the <link rel="stylesheet" type="text/css" href="css/comic.css"/> line:

<style>
    body {
        font-size: 20px;
    }
</style>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants