Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

target features should OR with filtered features #92

Closed
ergonyc opened this issue Oct 20, 2021 · 1 comment
Closed

target features should OR with filtered features #92

ergonyc opened this issue Oct 20, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@ergonyc
Copy link
Member

ergonyc commented Oct 20, 2021

the desired behavior of filtering features and target features would be to
first, test if target features are in ALL the database features (remove if not... maybe add NA row? future?)
second, union of filtered and target (OR operation)..

currently only allowing target features as subset of filtered features.
@ergonyc ergonyc added the enhancement New feature or request label Jan 19, 2022
@ergonyc
Copy link
Member Author

ergonyc commented Jan 19, 2022

closing and merging with #132

@ergonyc ergonyc closed this as completed Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ergonyc