Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

After updating to 3.0.0, the plugin does not detect translations in Editor #68

Closed
Gierand opened this issue Mar 24, 2023 · 5 comments
Closed

After updating to 3.0.0, the plugin does not detect translations in Editor #68

Gierand opened this issue Mar 24, 2023 · 5 comments
Labels
Bug Something isn't working, looks like a 🐛.

Comments

@Gierand
Copy link

Gierand commented Mar 24, 2023

Description

Does not detect translation to other languages in the Site/Post/Page Editor. On the settings page everything works fine.

Step-by-step reproduction instructions

  1. Add sample translated files to the directory:
    /wp-content/languages/plugins/block-visibility-de_DE.mo
    /wp-content/languages/plugins/block-visibility-de_DE-2b47503f90344d6580630a5c3c521589.json
    /wp-content/languages/plugins/block-visibility-de_DE-528469e0eb827b69963521f596eeae41.json
  2. Check Editor if the translation has been detected.

System information

  • Block Visibility version: 3.0.0
  • WordPress version: 6.1.1 & 6.2-RC4
  • Gutenberg version: 15.4.0
  • Are all plugins except Block Visibility, Block Visibility Pro (if installed), and Gutenberg (if installed) deactivated? Yes
  • Are you using a default theme (e.g. Twenty Twenty-Three)? Yes
@ndiego ndiego added the Bug Something isn't working, looks like a 🐛. label Mar 24, 2023
@ndiego
Copy link
Owner

ndiego commented Mar 24, 2023

Thanks for reporting @Gierand, I'll look into it! 💪

@ndiego
Copy link
Owner

ndiego commented Mar 25, 2023

Fixed in v3.0.1.

@ndiego ndiego closed this as completed Mar 25, 2023
@Gierand
Copy link
Author

Gierand commented Mar 26, 2023

Thank you!

@Gierand
Copy link
Author

Gierand commented Mar 27, 2023

@ndiego, Yet another little thing. The string "Custom Sets" does not have a text domain.

bv

@ndiego
Copy link
Owner

ndiego commented Apr 8, 2023

You are 100% correct. That string is missing a text domain 🤦‍♂️ I'll get that fixed up in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working, looks like a 🐛.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Gierand @ndiego