Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.3.3 not fully reflected? #219

Closed
sourabhxyz opened this issue Nov 13, 2022 · 2 comments · Fixed by #220
Closed

v2.3.3 not fully reflected? #219

sourabhxyz opened this issue Nov 13, 2022 · 2 comments · Fixed by #220

Comments

@sourabhxyz
Copy link

Hi, my package.json file tells that I am on version 2.3.3 ("react-countdown": "^2.3.3",) but latest update to onComplete is not reflected (as it is not firing up when given date was already passed) and when I navigate to its type, I see readonly onComplete?: CountdownTimeDeltaFn | LegacyCountdownProps['onComplete'];
image
And not

readonly onComplete?: (
    timeDelta: CountdownTimeDelta,
    completedOnStart: boolean
  ) => void | LegacyCountdownProps['onComplete'];

I installed the package via yarn.

@sourabhxyz
Copy link
Author

Can see in this sandbox link.

@ndresx ndresx mentioned this issue Nov 16, 2022
@ndresx
Copy link
Owner

ndresx commented Nov 16, 2022

Hi @sourabhxyz, yes, you are correct. Many thanks for noticing and reporting this issue!

This should be fixed with the latest release https://www.npmjs.com/package/react-countdown/v/2.3.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants