Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infinite renderer #97

Closed
PolinaBobrovnik opened this issue Oct 5, 2020 · 3 comments · Fixed by #100
Closed

Infinite renderer #97

PolinaBobrovnik opened this issue Oct 5, 2020 · 3 comments · Fixed by #100
Assignees
@ndresx
Labels
bug

Comments

@PolinaBobrovnik
Copy link

I noticed that if you pass date before Date.now() then renderer is executed infinitely with complete = true. Is it expected behavior?
@ndresx
Copy link
Owner

ndresx commented Oct 5, 2020

Hi @PolinaBobrovnik! Thank you for reporting this issue. This is not the expected behavior and should get only executed only once in this case.

@ndresx ndresx self-assigned this Oct 5, 2020
@SK-CSE
Copy link

SK-CSE commented Oct 7, 2020

yes a similar issue is happening if we want to reload the class component itself after the timer finished
detail

@ndresx ndresx mentioned this issue Oct 9, 2020
Merged
@ndresx
Copy link
Owner

ndresx commented Oct 13, 2020

This issue has been fixed now in the latest version. Thanks again for taking the time to report this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ndresx ndresx

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

v2.3.0 ndresx/react-countdown
3 participants
@SK-CSE @PolinaBobrovnik @ndresx