Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete Account needs to check for running pods before deleting PVC #288

Open
bodom0015 opened this issue Sep 11, 2019 · 1 comment
Open

Comments

@bodom0015
Copy link
Member

bodom0015 commented Sep 11, 2019

Our current Delete Account apparently does not wait for pods to shut down, which creates a race condition. The PVC is deleted immediately, and this causes any pods that are still running to fail to shutdown because the PVC fails to unmount.

We should check for running pods before deleting an account, and have a few options for handling this case:

  1. any running pods could be shut down, with the PVC to be deleted afterward
  2. we could trigger an error that prevents the account from being deleted
@bodom0015
Copy link
Member Author

This could probably just trigger a DELETE on the namespace. This way, Kubernetes handles all of the shutdown procedures in the background and should do everything in the right order to ensure the namespace is cleaned up completely

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant