Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix requester usage #70

Merged
merged 5 commits into from
Apr 27, 2022
Merged

Fix requester usage #70

merged 5 commits into from
Apr 27, 2022

Conversation

maelle
Copy link
Contributor

@maelle maelle commented Apr 26, 2022

Fix #69

@nealrichardson
Copy link
Owner

Thanks a lot! Can you add a test that reproduces the issue?

@nealrichardson
Copy link
Owner

Also FWIW I believe this is fixed in httptest2: https://github.com/nealrichardson/httptest2/blob/main/R/capture-requests.R#L95

@maelle
Copy link
Contributor Author

maelle commented Apr 27, 2022

Will do! I'll first have to experiment with this branch for another problem I'm having (a mock file that isn't found on some OS) then I'll ping you again. Thanks for your patience.

I wish I could use httptest2 but we use a dependency that uses httr. 😅

@maelle maelle marked this pull request as draft April 27, 2022 10:04
@codecov-commenter
Copy link

codecov-commenter commented Apr 27, 2022

Codecov Report

Merging #70 (ee97fd3) into master (cb1739c) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #70   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines          464       464           
=========================================
  Hits           464       464           
Impacted Files Coverage Δ
R/capture-requests.R 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb1739c...ee97fd3. Read the comment docs.

@maelle maelle marked this pull request as ready for review April 27, 2022 12:18
Copy link
Owner

@nealrichardson nealrichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nealrichardson nealrichardson merged commit 5fc2be9 into nealrichardson:master Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem with with_mock_dir()/gsub_request()
3 participants