-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix requester usage #70
Fix requester usage #70
Conversation
Thanks a lot! Can you add a test that reproduces the issue? |
Also FWIW I believe this is fixed in httptest2: https://github.com/nealrichardson/httptest2/blob/main/R/capture-requests.R#L95 |
Will do! I'll first have to experiment with this branch for another problem I'm having (a mock file that isn't found on some OS) then I'll ping you again. Thanks for your patience. I wish I could use httptest2 but we use a dependency that uses httr. 😅 |
Codecov Report
@@ Coverage Diff @@
## master #70 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 18 18
Lines 464 464
=========================================
Hits 464 464
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Fix #69