Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TESTCOV: Sputnik DAO: Proposals #127

Open
2 tasks
TrevorJTClarke opened this issue Feb 25, 2022 · 1 comment
Open
2 tasks

TESTCOV: Sputnik DAO: Proposals #127

TrevorJTClarke opened this issue Feb 25, 2022 · 1 comment
Labels
C-Testing Unit testing / integration testing P-Medium Priority: Medium
Milestone
Unit & Workspace ...

Comments

@TrevorJTClarke
Copy link
Contributor

TrevorJTClarke commented Feb 25, 2022 •
edited
Loading

Check the following logic is covered with tests, this was possibly missed or could not be confirmed as covered.

Proposals

on_proposal_callback

Receiving callback after the proposal has been finalized.

  • If successful, should return bond money to the proposal originator
  • If the proposal execution failed (funds didn't transfer or function call failure), should move the proposal to the "Failed" state
@TrevorJTClarke TrevorJTClarke added P-Medium Priority: Medium C-Testing Unit testing / integration testing labels Feb 25, 2022
@GaloisField2718
Copy link

Hello,
Is it implementing ?
Where we can specify that we want this option ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-Testing Unit testing / integration testing P-Medium Priority: Medium
Projects
Sputnik Core
Status: No status
Milestone
Unit & Workspace Test Expansion
Development

No branches or pull requests
2 participants
@TrevorJTClarke @GaloisField2718