Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEP4::check_access isn't to spec #152

Closed
joshuajbouw opened this issue May 15, 2021 · 3 comments
Closed

NEP4::check_access isn't to spec #152

joshuajbouw opened this issue May 15, 2021 · 3 comments

Comments

@joshuajbouw
Copy link

joshuajbouw commented May 15, 2021

Been looking through the library and had noticed that the NFT example technically isn't to spec on the check_access method.

As per spec it states:
export function check_access(token_id: TokenId): boolean;

which translates to:
fn check_access(&self, token_id: TokenId) -> bool;
in Rust.

However, the NFT example has fn check_access(&self, account_id: AccountId) -> bool; as its method.

References:

@joshuajbouw joshuajbouw changed the title NEP4::check_access technically isn't to spec NEP4::check_access isn't to spec May 15, 2021
@joshuajbouw
Copy link
Author

Closing this for now as I realise that NEP-141 is the standard.

@alexauroradev
Copy link

NEP-141 is a standard for fungible tokens. NEP-4 was never accepted. And now there's a new standard for NFTs, though I don't know what is the number for it. @mikedotexe owns this.

@joshuajbouw
Copy link
Author

NEP-171

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants