Add as-pect example test #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mikedotexe I can't restart the test, is it possible to merge without tests passing? |
mikedotexe
reviewed
Apr 3, 2020
blank_react_project/package.json
Outdated
| "<rootDir>/assembly/", | ||
| "<rootDir>/node_modules/" | ||
| ], | ||
| "runInBand": true |
There was a problem hiding this comment.
looks like they haven't added the ability for this to be in config yet, weird.
jestjs/jest#3215
|
While the test passed, there are two things I noticed here:
Not sure how long these have been around, but we should probably nip it in the bud now. Thoughts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.