Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Update the references to mainnet genesis file after a recent refactoring to nearcore #719

Closed
frol opened this issue May 25, 2021 · 2 comments · Fixed by #748
Closed
Assignees
Labels
bug Something isn't working

Comments

@frol
Copy link
Collaborator

frol commented May 25, 2021

image

After this PR near/nearcore#4292, the folder should be nearcore/res/

@frol frol added the bug Something isn't working label May 25, 2021
@thisisjoshford
Copy link
Collaborator

@frol Before I saw this issue just now, I noticed some broken links due to this refactor and started fixing them here ( #728
& #726 ). The solution I implemented was to tell people how to query this data via the protocol_config endpoint rather than linking to the config file directly. Should I continue on this path for the remaining links above in gas.MD or direct link to the new location? My thoughts are that if things get refactored or updated again the RPC endpoint will show the most current data and will minimize doc maintenance.

@frol
Copy link
Collaborator Author

frol commented May 28, 2021

@thisisjoshford yeah, using the protocol_config endpoint is even better! Thanks for pointing it out! I just used grep to find the broken links, and did not really dig into the reason why those links are used in the first place. Thanks for pointing that out! Should we close this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants