Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store pre-signatures using Redis #869

Open
wants to merge 40 commits into
base: develop
Choose a base branch
from

Conversation

volovyks
Copy link
Collaborator

@volovyks volovyks commented Oct 2, 2024

This is the setup of Docker in the same container. Some people consider it a bad practice, but it may be a simpler solution for node validators. I have no strong opinion here.

It is expected to be executed with

docker run -d \
  --name my-redis-rust-app \
  -v /path/on/host/redis-data:/var/lib/redis \
  -p 6379:6379 \
  -p 8080:8080 \
  my-redis-rust-app

It will persist the apend file on the VM.

cc @kmaus-near @ppca

@volovyks volovyks changed the title basic redis setup in the same container basic redis setup Oct 2, 2024
@ppca
Copy link
Contributor

ppca commented Oct 2, 2024

@kmaus-near How does your draft redis setup work? Is it different or similar to this?

@kmaus-near
Copy link
Collaborator

@kmaus-near How does your draft redis setup work? Is it different or similar to this?

My homelab setup uses a dedicated VM running a Redis container vs. baking it into the multichain image, but other than that similar configuration. @volovyks and myself discussed this a bit yesterday, it's not exactly the "best practice" but if we are trying to simplify this for our partners, this may be a better route. Plus if we are to run it locally, we are then going to be running 3 containers on a single VM if we do not bake it into the image itself, which is not ideal resource wise or best practice wise. In short, both are not ideal, but for different reasons 😂.

I would suggest that we try to keep the code interacting with Redis as decoupled as possible, so if in the future we need to separate Redis from the base image, we can do so easily.

@volovyks
Copy link
Collaborator Author

volovyks commented Oct 4, 2024

@kmaus-near all we need in code is the Redis URL, so it is not coupled. If we change how we manage Redis storage, most of the complexity will be on the Terraform side.

Dockerfile.multichain Outdated Show resolved Hide resolved
@volovyks volovyks changed the title basic redis setup Stora pre-signatures using Redis Oct 14, 2024
@volovyks volovyks changed the title Stora pre-signatures using Redis Store pre-signatures using Redis Oct 14, 2024
@volovyks volovyks linked an issue Oct 16, 2024 that may be closed by this pull request
Dockerfile.multichain Outdated Show resolved Hide resolved
@volovyks volovyks marked this pull request as ready for review October 21, 2024 23:28
@volovyks
Copy link
Collaborator Author

I've fixed an issue with Redis integration tests. Most of the tests fail because of the cashing (probably) issue.
TF setup was tested on one of the dev nodes (thanks @kmaus-near ).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Persist pre-signatures
5 participants