-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store pre-signatures using Redis #869
base: develop
Are you sure you want to change the base?
Conversation
@kmaus-near How does your draft redis setup work? Is it different or similar to this? |
My homelab setup uses a dedicated VM running a Redis container vs. baking it into the multichain image, but other than that similar configuration. @volovyks and myself discussed this a bit yesterday, it's not exactly the "best practice" but if we are trying to simplify this for our partners, this may be a better route. Plus if we are to run it locally, we are then going to be running 3 containers on a single VM if we do not bake it into the image itself, which is not ideal resource wise or best practice wise. In short, both are not ideal, but for different reasons 😂. I would suggest that we try to keep the code interacting with Redis as decoupled as possible, so if in the future we need to separate Redis from the base image, we can do so easily. |
@kmaus-near all we need in code is the Redis URL, so it is not coupled. If we change how we manage Redis storage, most of the complexity will be on the Terraform side. |
3a3bf87
to
feba156
Compare
edc4b9f
to
fde93fb
Compare
…/mpc-recovery into serhii/presignature-storage
…overy into serhii/presignature-storage
…/mpc-recovery into serhii/presignature-storage
I've fixed an issue with Redis integration tests. Most of the tests fail because of the cashing (probably) issue. |
This is the setup of Docker in the same container. Some people consider it a bad practice, but it may be a simpler solution for node validators. I have no strong opinion here.
It is expected to be executed with
It will persist the apend file on the VM.
cc @kmaus-near @ppca