Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a git hook to build the js files before commiting #701

Closed
volovyks opened this issue Sep 30, 2021 · 6 comments · Fixed by #723
Closed

Add a git hook to build the js files before commiting #701

volovyks opened this issue Sep 30, 2021 · 6 comments · Fixed by #723
Labels
devx good first issue Good for newcomers

Comments

@volovyks
Copy link
Collaborator

We are often forgetting to run yarn build before the push. Let's fix it once and for all.

@Rishabhraghwendra18
Copy link
Contributor

Rishabhraghwendra18 commented Nov 2, 2021

is this issue still open ? I will like to work on this

@volovyks
Copy link
Collaborator Author

volovyks commented Nov 2, 2021

@Rishabhraghwendra18 Yes, it is. You can work on it.

@Rishabhraghwendra18
Copy link
Contributor

Ok.. Thanks . I will make a PR for this today

@Rishabhraghwendra18
Copy link
Contributor

@volovyk-s do I need to install a dev package like Husky for Git Hooks because I can't find such any package in package.json

@volovyks
Copy link
Collaborator Author

volovyks commented Nov 9, 2021

@Rishabhraghwendra18 please, do all the necessary work, but do not push package.json and lock files. I will add this dependency myself if we will decide to merge your PR.

@Rishabhraghwendra18
Copy link
Contributor

ok sure

@volovyks volovyks linked a pull request Nov 19, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devx good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants