Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove near-api-js tests #1120

Merged
merged 5 commits into from
May 30, 2023
Merged

chore: remove near-api-js tests #1120

merged 5 commits into from
May 30, 2023

Conversation

andy-haynes
Copy link
Collaborator

@andy-haynes andy-haynes commented Apr 25, 2023

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • Commit messages follow the conventional commits spec
  • If this is a code change: I have written unit tests.
  • If this changes code in a published package: I have run pnpm changeset to create a changeset JSON document appropriate for this change.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

As part of the migration to @near-js packages, tests were copied into the new packages but also remained in the near-api-js package. The original tests provided a sanity check to ensure that test coverage was unaffected by the transition, and so have now fulfilled their purpose.

I've left the test harness in place should there be a need for new tests, but I don't expect this to happen.

As an added bonus there is no longer contention between the duplicate accounts tests, allowing tests to be run in parallel for massive time savings.

@changeset-bot
Copy link

changeset-bot bot commented Apr 25, 2023

⚠️ No Changeset found

Latest commit: aa4f79e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@morgsmccauley morgsmccauley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@andy-haynes andy-haynes merged commit fbc2395 into master May 30, 2023
@andy-haynes andy-haynes deleted the remove-naj-tests branch May 30, 2023 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants