This repository has been archived by the owner on Oct 4, 2024. It is now read-only.
Hit the node on IPv4 localhost rather than hostname by default #929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The localnet local node (probably the only reason for this default value) defaults to listening only on IPv4. Instead of defaulting on hostname-localhost, which would break on systems that default localhost to `::1`, use `127.0.0.1` by default. The better fix would be to actually have the node listen on IPv6, but this should be better than the current situation at least.
Even better would be to support failing over to IPv4 resolution in NodeJS, as mentioned in #881 (comment) |
|
Agreed, though it feels like it'd be much harder to do, especially if it needs to be implemented in NodeJS upstream; so in the meantime I think it makes sense to land that until NodeJS implements happy eyeballs |
volovyks
approved these changes
Feb 21, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The localnet local node (probably the only reason for this default value) defaults to listening only on IPv4.
Instead of defaulting on hostname-localhost, which would break on systems that default localhost to
::1, use127.0.0.1by default.The better fix would be to actually have the node listen on IPv6, but this should be better than the current situation at least.
Fixes #881