feat: js command #975
feat: js command #975
Conversation
|
@ChaoticTempest Looks cool. Let's fix the bug and merge. |
|
@ChaoticTempest Looks like the deploy_js_contract ignore the initFunction. As we don't have the support to batch deploy and call init function in the same transaction, there're two choices here:
|
|
@ailisp I don't think either of those options would guarantee us the safety of a batch transaction though unless point 2 is talking about that. JSVM should be able to schedule a promise that would allow us to do this |
|
@ChaoticTempest Sounds good! It would be perfect if JSVM does that as a promise but you're right on timeline. Currently, if contract is building with sdk-js's |
|
@ailisp @volovyk-s pushed |
|
It looks very solid and all good on my side! But I'm not often in maintaining near-cli, so let @volovyk-s double check it fits near-cli well. |
|
@ChaoticTempest we have working tests in master now. I will add them here. |
|
Nice work @ChaoticTempest ! Merging now. Let's add some docs and examples from your doc to the README in the next PR. |
| function base64_encode_args(contractId, functionName, args) { | ||
| let buf = Buffer.concat([ | ||
| Buffer.from(contractId), | ||
| Buffer.from([0]), |
There was a problem hiding this comment.
curiosity: why are 0 bytes included in-between these?
Initial work on the JS cli command which includes:
Getting this one out for now to see if we want to move in this kind of direction before going on to adding more subcommands