Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation error: unexpected cfg condition value: __abi-embed-checked #1223

Closed
frol opened this issue Jul 31, 2024 · 4 comments
Closed
Assignees
Labels

Comments

@frol
Copy link
Collaborator

frol commented Jul 31, 2024

CI fails in main branch are caused by the recent Rust 1.80 release that introduced cfg features checks:

image

https://blog.rust-lang.org/2024/07/25/Rust-1.80.0.html

We need to review the feature names and either properly name them, or add them to Cargo.toml.

@lauchaves
Copy link
Contributor

lauchaves commented Jul 31, 2024

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

Hey! I'm Lau Chaves, and I would like to contribute to this issue!

I just noticed it as well while running it locally and also on the PR I just created, I was gonna ask about it, thought it was related to the other pull request that hasn’t been merged.

My end
image

But now that I’ve context, I’d love to give it a try!

How I plan on tackling this issue

Here’s the approach I’d follow:

  • First I would review the error messages and identify which parts of the code are failing due to the new cfg features checks.
  • I’ll look for #[cfg(...)] and #[cfg_attr(...)]
  • I’ll review the Rust 1.80 release notes to understand the specific changes to cfg feature checks
  • I’ll update configuration, check .toml to ensure it’s defined correctly
  • I’ll fix all the cfg that are misconfigured
  • I’ll run tests in order to check that issues are resolved and no new issues have been introduced

@frol
Copy link
Collaborator Author

frol commented Jul 31, 2024

@lauchaves See this comment with a potential solution being proposed: https://t.me/NEAR_Tools_Community_Group/2774

@frol
Copy link
Collaborator Author

frol commented Jul 31, 2024

@lauchaves yes, that one line fix addresses the first compilation error, but there are more, please, pick it up from there: #1225

@lauchaves
Copy link
Contributor

@frol alright, will do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants