Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some VMContext attributes can cause confusion #14

Open
jasperdg opened this issue Sep 4, 2019 · 1 comment
Open

Some VMContext attributes can cause confusion #14

jasperdg opened this issue Sep 4, 2019 · 1 comment

Comments

@jasperdg
Copy link

jasperdg commented Sep 4, 2019

  • input is a bit vague and some documentation on this attribute would be nice.
  • I'm assuming attached_deposit is the amount of NEAR that's being send with current TX,
    this might be confusing because a deposit sounds very specific, something like transaction_value (in Solidity it's just value) might make more sense.
  • signer_account_pk confused me because I thought it stood for private key. Maybe change it to something more similar to signer_account_pub_key.
@MaksymZavershynskyi
Copy link
Contributor

Moving to backlog since we will be cleaning near-bindgen soon anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: NEW❗
Development

No branches or pull requests

2 participants