Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address unit tests using old nearcore version #500

Closed
mikedotexe opened this issue Jul 27, 2021 · 1 comment
Closed

Address unit tests using old nearcore version #500

mikedotexe opened this issue Jul 27, 2021 · 1 comment

Comments

@mikedotexe
Copy link
Contributor

mikedotexe commented Jul 27, 2021

This issue is created to track a problem brought up in this comment:
#481 (comment)

Let's revisit the old version being used and untangle what's needed. At this time I am not prepared with a summary for why we've been using this old version, but we can flesh out this description as it becomes more of a pressing matter.

It's probable that there's some knowledge to glean from the great writeup here: https://github.com/near/near-sdk-rs/issue/372

@austinabell
Copy link
Contributor

I'm confused, what do you suggest we do? We are using the most recent version of near-vm-logic (4.0.0-pre.1) and near-primitives-core (0.4.0).

I have this point in part of #494 as it is also required to update our borsh version, but do we have control over when and how these nearcore packages are released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants