Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add_access_key test coverage #516

Closed
austinabell opened this issue Aug 4, 2021 · 2 comments
Closed

add_access_key test coverage #516

austinabell opened this issue Aug 4, 2021 · 2 comments
Labels
good first issue Good for newcomers good_first_issue T-dev-tools

Comments

@austinabell
Copy link
Contributor

austinabell commented Aug 4, 2021 •
edited by exalate-issue-sync bot
Loading

Noticed when making changes to these signatures that we have no usages or test coverage for this functionality.

Ideally would be nice to have something close to an e2e test, but using the mocked blockchain should be sufficient just to make sure core functionality is correct and the API doesn't change unnecessarily.

This could test through a Promise initialization, and could test the env calls directly
@austinabell austinabell added the good first issue Good for newcomers label Aug 4, 2021
@frol frol added the good first issue Good for newcomers label Jun 4, 2023
@agostbiro
Copy link
Contributor

I'm looking into this

@agostbiro agostbiro mentioned this issue Jun 21, 2023
Merged
@frol
Copy link
Collaborator

frol commented Jun 23, 2023

Resolved in #1029

@frol frol closed this as completed Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers good_first_issue T-dev-tools
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@frol @agostbiro @austinabell