Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show 'total' number of NFTs per contract #2320

Merged
merged 7 commits into from
Jan 5, 2022
Merged

Show 'total' number of NFTs per contract #2320

merged 7 commits into from
Jan 5, 2022

Conversation

marcinbodnar
Copy link
Contributor

No description provided.

@render
Copy link

render bot commented Dec 20, 2021

@marcinbodnar marcinbodnar linked an issue Dec 20, 2021 that may be closed by this pull request
@marcinbodnar
Copy link
Contributor Author

@corwinharrell @Patrick1904 Maybe a good idea would be to show the loaded number of tokens and the total number, something like "4 of 8"? With this change, it's a bit weird when the number near the contract name shows for example 10, and the user sees only 4 nfts. But definitely not a blocker.

Copy link
Contributor

@Patrick1904 Patrick1904 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one Marcin 👍

@marcinbodnar marcinbodnar merged commit 70805f2 into master Jan 5, 2022
@marcinbodnar marcinbodnar deleted the issue-2262 branch January 5, 2022 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show 'total' number of NFTs per contract
2 participants