Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update staking farm related copy #2388

Merged
merged 6 commits into from
Jan 21, 2022
Merged

Conversation

MaximusHaximus
Copy link
Contributor

  1. Alphabetizes the JSON files now that we have automatic tooling added to handle this whenever they are edited
  2. Updates copy for token farm validators

@render
Copy link

render bot commented Jan 20, 2022

@MaximusHaximus
Copy link
Contributor Author

@corwinharrell Would like your input on the new tooltip text and the new balance of tokens earned via the staking farm.

                "info": "This is a 'staking farm'. You will receive tokens other than NEAR as rewards while staking on it.",
                "title": "Un-claimed farm tokens earned"

@heycorwin
Copy link
Contributor

@MaximusHaximus Could you add screenshots of the affected UI in context? Just helps to review things like this without going through setup locally. Would love to get into a habit of this any time there are changes that affect the front-end/UI

@MaximusHaximus
Copy link
Contributor Author

@corwinharrell You don't need to set anything up locally to see how changes look in context, since we automatically deploy previews for every PR with both testnet and mainnet configurations.

  • You can see link for the mainnet staging preview under the 'checks' area of the PR at the bottom of this screen -- click 'Details' next to the row labelled netlify/near-wallet-staging/deploy-preview — Deploy Preview ready!.
  • You can see the testnet preview build by using the link in the comment that Render added to this PR as the first response comment (chore: Update staking farm related copy #2388 (comment))

Here's a picture of the screen with the new terms being rendered for your convenience, but it would probably be a good idea for you to get in the habit of using the preview builds in general, since screenshots are pretty limited (especially for changes that can impact multiple screens)
image

@heycorwin
Copy link
Contributor

Sorry for the miscommunication @MaximusHaximus. I'm totally comfortable using the deploy links. My comment about adding an image was purely an aside and for convenience sake for future PRs. Didn't mean to suggest it was a blocker. Had to step away for a bit this afternoon but looking at this now.

@heycorwin
Copy link
Contributor

@MaximusHaximus See this comment: #2383 (comment) since I think it has a direct impact on the changes proposed in this PR.

@MaximusHaximus
Copy link
Contributor Author

@corwinharrell I modified the UI to look like the picture you've created, and modified the translation terms accordingly -- thanks for the feedback/direction!

@MaximusHaximus MaximusHaximus merged commit e4f29de into master Jan 21, 2022
@MaximusHaximus MaximusHaximus deleted the staking-farm-copy branch January 21, 2022 04:19
@MaximusHaximus
Copy link
Contributor Author

@Patrick1904 I'm pretty sure my usage of dynamic props for the container here isn't what you'd want given I haven't seen this pattern in other code -- I'm shipping with that setup in the interest of time but am keen to have a chat with you when you're back about the right way to handle the border formatting in the list 'the right way, and to understand the benefits of avoiding dynamic props usage for our style components if that's what we're generally trying to do as a team. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants