Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2022-01-19 Release #2389

Merged
merged 330 commits into from
Jan 21, 2022
Merged

2022-01-19 Release #2389

merged 330 commits into from
Jan 21, 2022

Conversation

esaminu and others added 30 commits December 22, 2021 20:14
Chore: Improve linting & auto-alphabetize translations
Copy link
Contributor

@heycorwin heycorwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Looks like there is still some copy that was not updated in the new flow: Once the implicit account is created, the module on the dashboard reads: "Add a Custom Address..." Once the user clicks through to perform this action, the next screen reads "Reserve Account ID". Instead it should read "Add a Custom Address". We need to ensure that all of the copy is consistent with the new designs, and that this screen in particular is updated, since it contains important contextual information. cc @Patrick1904

  2. The following step is still present in the new flow:

Screen Shot 2022-01-20 at 12 49 42 PM

What we had agreed on was that this step would be eliminated in favor of defaulting to funding the new custom address with the active account. Persisting the manual deposit option here means that the user has the option to fund their new custom address via sending funds to yet another temporary implicit account, which defeats the purpose of this work entirely. These options should not persist, since this flow assumed the active account has enough funds to create a new named account, and will be the one to fund it.

@MaximusHaximus MaximusHaximus merged commit 5aecfab into stable Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants