-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2022-01-19 Release #2389
2022-01-19 Release #2389
Conversation
MaximusHaximus
commented
Jan 20, 2022
•
edited
Loading
edited
- Chore: Improve linting & auto-alphabetize translations #2294
- Show 'total' number of NFTs per contract #2320
- Retry transaction if gas is insufficient #2216
- https://github.com/near/near-wallet/issues/2330 #2337
- (FIX) Typo #2350
- fix: compute liquid amount locally instead of fetching #2342
- Sign transaction doc #2333
- docs: add docs for fungible token discovery and display #2347
- feat: add prompts to add and remove environments #2352
- ADD defaults & check for valid NEAR_WALLET_ENV #2299
- Add new /sign UI #2215
- Fix iOS button appearance style bug #2361
- fix: debug staging banner configuration #2362
- E2e ci localserver #2174
- chore: Add pre-commit hook to run lint fix and JSON alpha sort #2367
- Docs: Login with NEAR Wallet #2336
- Configure Jest for .env support #2359
- Update Portuguese translation and missing terms #2274
- Display farm token rewards #2384
- Implicit addresses as default for first-time account creation #2313
- docs: add docs for non-fungible token discovery and display #2356
- Lockup e2e tests #2264
- Create Account: only show verification options if funding is available #2385
- Fund account with implicit flow #2390
- chore: Update staking farm related copy #2388
Chore: Improve linting & auto-alphabetize translations
Display farm token rewards
Implicit addresses as default for first-time account creation
docs: add docs for non-fungible token discovery and display
Lockup e2e tests
Create Account: only show verification options if funding is available
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
Looks like there is still some copy that was not updated in the new flow: Once the implicit account is created, the module on the dashboard reads: "Add a Custom Address..." Once the user clicks through to perform this action, the next screen reads "Reserve Account ID". Instead it should read "Add a Custom Address". We need to ensure that all of the copy is consistent with the new designs, and that this screen in particular is updated, since it contains important contextual information. cc @Patrick1904
-
The following step is still present in the new flow:
What we had agreed on was that this step would be eliminated in favor of defaulting to funding the new custom address with the active account. Persisting the manual deposit option here means that the user has the option to fund their new custom address via sending funds to yet another temporary implicit account, which defeats the purpose of this work entirely. These options should not persist, since this flow assumed the active account has enough funds to create a new named account, and will be the one to fund it.
Fund account with implicit flow
Also added loading 'dots' so that it is clear when we are still fetching farm details
…r is provided as a prop (equal spacing between entries)
chore: Update staking farm related copy