Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't specify own RPC and own keystore path #195

Closed
joshuajbouw opened this issue Sep 20, 2022 · 1 comment
Closed

Can't specify own RPC and own keystore path #195

joshuajbouw opened this issue Sep 20, 2022 · 1 comment
Labels
good first issue Good for newcomers

Comments

@joshuajbouw
Copy link
Member

Right now, the RPC and archival RPCs are hard coded to the <Network>::new() methods which only use hard-coded keystore_paths and rpc_url, both of which are required for our needs to be set differently.

Solution

An ideal solution would be to implement Default for Mainnet/Testnet which includes the default key paths and RPC URL. Finally, pub(crate) async fn new() -> Result<Self> should be instead pub async fn new<P: AsRef<Path>>(keystore_path: P, rpc_url: String) -> Result<Self>.

Optionally, the same treatment can be done for Sandbox.

@frol frol added the good first issue Good for newcomers label Jun 6, 2023
@frol
Copy link
Collaborator

frol commented Jun 26, 2023

@frol frol closed this as completed Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants