You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Right now, the RPC and archival RPCs are hard coded to the <Network>::new() methods which only use hard-coded keystore_paths and rpc_url, both of which are required for our needs to be set differently.
Solution
An ideal solution would be to implement Default for Mainnet/Testnet which includes the default key paths and RPC URL. Finally, pub(crate) async fn new() -> Result<Self> should be instead pub async fn new<P: AsRef<Path>>(keystore_path: P, rpc_url: String) -> Result<Self>.
Optionally, the same treatment can be done for Sandbox.
The text was updated successfully, but these errors were encountered:
Right now, the RPC and archival RPCs are hard coded to the
<Network>::new()
methods which only use hard-codedkeystore_path
s andrpc_url
, both of which are required for our needs to be set differently.Solution
An ideal solution would be to implement
Default
forMainnet
/Testnet
which includes the default key paths and RPC URL. Finally,pub(crate) async fn new() -> Result<Self>
should be insteadpub async fn new<P: AsRef<Path>>(keystore_path: P, rpc_url: String) -> Result<Self>
.Optionally, the same treatment can be done for
Sandbox
.The text was updated successfully, but these errors were encountered: