Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fast_forward misleading name #229

Closed
austinabell opened this issue Nov 2, 2022 · 0 comments · Fixed by #299
Closed

fast_forward misleading name #229

austinabell opened this issue Nov 2, 2022 · 0 comments · Fixed by #299

Comments

@austinabell
Copy link
Contributor

Intuitively I would expect fast_forward to progress the state transitions as if the time had passed naturally. Opening issue because I (and potentially others) might be surprised to find out it just progresses the block height, timestamp, and epoch and leaves the current in-flight transactions as-is.

My argument for why it should progress the transactions is that testing transaction ordering is very non-deterministic and relies on manually waiting in tests. Having fast_forward progress the transactions doesn't solve the non-determinism, but can make it much harder to hit.

At very least, the docs for fast_forward should indicate that any receipts that are scheduled and have not been executed will not be progressed during this call, I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant