Weekly update 2021-03-25

[frol]

Last week update is here: #4138

Done

• nearcore:
  • refactored TryFrom<&str> -> FromStr
• near-cli v2 (in Rust): New near-cli using the following design is coming!
• indexer:
  • We shut down near-indexer-for-wallet (in favor of near-indexer-for-explorer)
  • Mario: reproduced a bug with running from a backup reported by the community, and it seems to be nearcore issue (not indexer-specific)
• balances:
  • the first draft of the balances documentation is done
• borsh-rs: a new minor release happened 0.9.0 (unsafe behaviors is now explicitly unsafe) (@frol)

Plans

• meta: OKRs draft is getting ready (@frol)
• nearcore:
  • broadcast_tx_* endpoints are getting refactored (already identified the possible errors) (@khorolets)
  • Refactor health and status to the structured errors (@chefsale)
  • Guard query(view_state) JSON RPC endpoint rejecting the calls to the accounts with "big" state (storage usage > N bytes) Reject view_state JSON RPC requests for big accounts #3950 (@bowenwang1996)
• balances:
  • keep confirming the sanity of the balances in the indexer database (@telezhnaya)

Discussions

• Olga: What is the treasury concept? (continued from last week)
  • Bowen: 10% of validation reward goes to it, it is a network sustainability account
  • Olga: There is a discrepancy in 3 yoctoNEAR
  • Bowen: It is a rounding issue, now it is a part of the protocol
• Bowen: Do we have tests for RPC errors?
  • Frol: Not many of them
  • Bohdan: We update those that are too generic to be more specific
• Bohdan: Where should we put the tests? (pytest, neard/tests, ...)
  • Bowen: It depends on the nature of the test (integration vs "unit"-test)