Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename PeerStore #10096

Open
saketh-are opened this issue Nov 3, 2023 · 0 comments
Open

Rename PeerStore #10096

saketh-are opened this issue Nov 3, 2023 · 0 comments
Assignees
@saketh-are
Labels
A-network Area: Network C-housekeeping Category: Refactoring, cleanups, code quality T-core Team: issues relevant to the core team

Comments

@saketh-are
Copy link
Collaborator

PeerStore contents used to be persisted to the DB, hence the name. It follows the convention of other ___Store types in our codebase. Since #8617 it is kept in-memory only. We should rename it to something like PeerInfoCache.
@saketh-are saketh-are added C-housekeeping Category: Refactoring, cleanups, code quality A-network Area: Network T-core Team: issues relevant to the core team labels Nov 3, 2023
@saketh-are saketh-are self-assigned this Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@saketh-are saketh-are

Labels
A-network Area: Network C-housekeeping Category: Refactoring, cleanups, code quality T-core Team: issues relevant to the core team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@saketh-are