Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit number of computations of routing table to one #3892

Closed
pmnoxx opened this issue Feb 3, 2021 · 0 comments · Fixed by #3891
Closed

Limit number of computations of routing table to one #3892

pmnoxx opened this issue Feb 3, 2021 · 0 comments · Fixed by #3891
Assignees
@pmnoxx
Labels
A-network Area: Network

Comments

@pmnoxx
Copy link
Contributor

pmnoxx commented Feb 3, 2021

I have seen cases, where we would schedule computation of routing table thousands of times. This is not optimal.

Feb 02 20:59:38.108  INFO near_performance_metrics::stats_enabled: Futures waiting for completion     
...
Feb 02 20:59:38.114  INFO near_performance_metrics::stats_enabled:     future chain/network/src/peer_manager.rs:575 2182  
... ```
@pmnoxx pmnoxx self-assigned this Feb 3, 2021
@pmnoxx pmnoxx linked a pull request Feb 3, 2021 that will close this issue
change peer_manager not to recompute routing multiple times #3891
Merged
@bowenwang1996 bowenwang1996 added the A-network Area: Network label Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pmnoxx pmnoxx

Labels
A-network Area: Network
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

change peer_manager not to recompute routing multiple times near/nearcore
2 participants
@pmnoxx @bowenwang1996