Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let param-estimator estimate subset of RuntimeConfig fees #4501

Closed
Longarithm opened this issue Jul 13, 2021 · 2 comments
Closed

Let param-estimator estimate subset of RuntimeConfig fees #4501

Longarithm opened this issue Jul 13, 2021 · 2 comments
Labels
A-contract-runtime Area: contract compilation and execution, virtual machines, etc A-params-estimator Area: runtime params estimator T-contract-runtime Team: issues relevant to the contract runtime team

Comments

@Longarithm
Copy link
Member

Currently param-estimator runs for ~8 hours. If we want to debug some specific fee, we still have to run the whole script by default. Also, we can't just comment all fees or metrics except one, because some of them depend on others (see upper_with_base calls).

I speeded it up to compute deploy contract fees as follows: master...disable-estimates. It runs for ~10 minutes. Still, this way is quite hacky.

cc @matklad

@Longarithm Longarithm added the A-params-estimator Area: runtime params estimator label Jul 13, 2021
@bowenwang1996 bowenwang1996 added A-contract-runtime Area: contract compilation and execution, virtual machines, etc T-contract-runtime Team: issues relevant to the contract runtime team labels Jul 13, 2021
@stale
Copy link

stale bot commented Oct 11, 2021

This issue has been automatically marked as stale because it has not had recent activity in the last 2 months.
It will be closed in 7 days if no further activity occurs.
Thank you for your contributions.

@stale stale bot added the S-stale label Oct 11, 2021
@matklad
Copy link
Contributor

matklad commented Oct 12, 2021

That's actually fixed. On the old estimator, you can use --metrics-to-measure to select metrics, which helps somewhat. On the new estimator, the same --metrics-to-measure flag selects actual costs, and indeed does the minimal amount of work.

@matklad matklad closed this as completed Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-contract-runtime Area: contract compilation and execution, virtual machines, etc A-params-estimator Area: runtime params estimator T-contract-runtime Team: issues relevant to the contract runtime team
Projects
None yet
Development

No branches or pull requests

3 participants