-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nodes need termination signal #718
Comments
Having this feature will also fix an issue with terminating our storage. Which causes errors. Every now and then our tests complete successfully, but upon termination barf a SIGSEGV or SIGABRT. This behavior is similar to what Parity experiences in their storage code and might be an issue with rocksdb itself: openethereum/parity-ethereum#6213 From @bowenwang1996 's PR that he submitted (https://gitlab.com/nearprotocol/nearcore/-/jobs/177030804):
From my PR that I have not submitted yet (https://gitlab.com/nearprotocol/nearcore/-/jobs/177128839):
P.S. |
This issue is still happening. See: https://gitlab.com/nearprotocol/nearcore/-/jobs/197901603
|
With Actix we have a nice System::current().stop() that sends stop signal to all actors. |
Nodes need termination signal for testing.
See
test_alphanet.rs
, we cannot have more than one test per file because they consume CPU so much that if they run in parallel they timeout. We could introduce mutex to make sure we run only one at a time, however there is not way to stop a group of nodes.The text was updated successfully, but these errors were encountered: