Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve flat storage tests coverage #8500

Closed
2 of 4 tasks
exalate-issue-sync bot opened this issue Feb 3, 2023 · 3 comments
Closed
2 of 4 tasks

Improve flat storage tests coverage #8500

exalate-issue-sync bot opened this issue Feb 3, 2023 · 3 comments
Assignees

Comments

@exalate-issue-sync
Copy link

exalate-issue-sync bot commented Feb 3, 2023

Plan:


First ideas of what we should do:

  • Uncomment and fix test_state_sync currently marked with #[cfg(not(feature = "protocol_feature_flat_state"))]
  • Introduce FlatStorageCreationStatus::SyncingState when we sync flat storage state for given shard during state sync or catchup. Use it to crash if we attempt to initiate background migration, and vice versa - if we attempt to sync flat storage when background migration didn't end.
  • If background migration is running but the block for which we create it got GC-d (see Chain.clear_data), we should interrupt node
@Longarithm
Copy link
Member

Longarithm commented Feb 16, 2023

When we attempted to implement debug tool and add support for params-estimator, there was several notable design challenges discovered. This resulted in several discussions on how we could design better API for flat storage and cleanup the code after we implemented prototype. Anton started working on it and created an issue #8577

@Longarithm
Copy link
Member

See #8577 for more granular progress.
#8664 which splits flat storage into multiple files was merged today.

@Longarithm
Copy link
Member

Strictly speaking, we don't have 100% progress here, because #8577 had more priority and was much more complex.
Still we implemented some tests, so I dump remaining issues to the newly created #8826 and close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant