Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate EpochManager from Runtime #8515

Closed
2 tasks done
Tracked by #8512
robin-near opened this issue Feb 6, 2023 · 0 comments · Fixed by #8357, #8767, #8768, #8769 or #8778
Closed
2 tasks done
Tracked by #8512

Separate EpochManager from Runtime #8515

robin-near opened this issue Feb 6, 2023 · 0 comments · Fixed by #8357, #8767, #8768, #8769 or #8778
Assignees
@robin-near

Comments

@robin-near
Copy link
Contributor

robin-near commented Feb 6, 2023 •
edited
Loading

The following are needed to remove Runtime dependency from ShardsManager and to fulfill the testability goal of ShardsManager:

There are many other tasks not yet scoped for separating EpochManager from RuntimeAndEpochManagerAdapter in general.
@robin-near robin-near mentioned this issue Feb 6, 2023
Open
4 tasks
@robin-near robin-near self-assigned this Mar 2, 2023
This was linked to pull requests Jul 19, 2023
[Runtime Epoch Split] (1/n) Split RuntimeAdapter to separate trait, and rename combined trait to RuntimeAndEpochManagerAdapter #8357
Merged
[Runtime Epoch Split] (2/n) Narrow EpochManagerAdapter error type to EpochError wherever possible. #8767
Merged
[Runtime Epoch Split] (3/n) Add ability to get Arc<EpochManagerAdapter> out of an &RuntimeWithEpochManagerAdapter. #8768
Merged
[Runtime Epoch Split] (4/n) Make ShardTracker accessible from RuntimeWithEpochManagerAdapter. #8769
Merged
[Runtime Epoch Split] (5/n) Migrate ShardsManager to use only EpochManager and ShardTracker. #8778
Merged
[Runtime Epoch Split] (6/n) Refactor state-viewer away from RuntimeWithEpochManagerAdapter. #8917
Merged
[Runtime Epoch Split] (7/n) Split runtime everywhere else #8940
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robin-near robin-near

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Runtime Epoch Split] (1/n) Split RuntimeAdapter to separate trait, and rename combined trait to RuntimeAndEpochManagerAdapter robin-near/nearcore
[Runtime Epoch Split] (2/n) Narrow EpochManagerAdapter error type to EpochError wherever possible. near/nearcore
[Runtime Epoch Split] (3/n) Add ability to get Arc<EpochManagerAdapter> out of an &RuntimeWithEpochManagerAdapter. near/nearcore
[Runtime Epoch Split] (4/n) Make ShardTracker accessible from RuntimeWithEpochManagerAdapter. near/nearcore
[Runtime Epoch Split] (5/n) Migrate ShardsManager to use only EpochManager and ShardTracker. robin-near/nearcore
[Runtime Epoch Split] (6/n) Refactor state-viewer away from RuntimeWithEpochManagerAdapter. robin-near/nearcore
[Runtime Epoch Split] (7/n) Split runtime everywhere else robin-near/nearcore
1 participant
@robin-near