fix: resolve actix memory leak #2606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
frol
approved these changes
May 4, 2020
| @@ -39,6 +39,9 @@ members = [ | |||
| "tools/restaked" | |||
| ] | |||
|
|
|||
| [dependencies] | |||
| actix-rt = "=1.1.1" | |||
There was a problem hiding this comment.
Let's have a comment right there with the link to the issue and some context, so it is immediately obvious why this was done. Do you think it makes sense to pin it instead of just requiring 1.1.1, which in semver means 1.1.1+?
There was a problem hiding this comment.
I think it makes sense to pin the exact version for now. This is only intended to serve as a temporary solution. A longer term solution would be to update all the actix libraries when they update actix-rt version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pins
actix-rtversion1.1.1to fix the memory leak caused by actix/actix-net#129. Resolve #2593.Test plan
Existing tests pass.