Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't add transactions to a pool in non-validator nodes #6713

Merged
merged 7 commits into from
May 2, 2022
Merged

Don't add transactions to a pool in non-validator nodes #6713

merged 7 commits into from
May 2, 2022

Conversation

nikurt
Copy link
Contributor

@nikurt nikurt commented Apr 28, 2022 •
edited
Loading

This fixes an issue of the transaction pool growing indefinitely in non-RPC nodes.

Issue #3284

@nikurt nikurt requested a review from mm-near April 28, 2022 15:41
@nikurt nikurt requested a review from a team as a code owner April 28, 2022 15:41
mm-near
mm-near suggested changes Apr 29, 2022
View reviewed changes
chain/chunks/src/lib.rs Show resolved Hide resolved
@nikurt nikurt requested a review from mm-near May 2, 2022 09:32
mm-near
mm-near approved these changes May 2, 2022
View reviewed changes
chain/client/src/client.rs Outdated Show resolved Hide resolved
chain/client/src/client.rs Show resolved Hide resolved
@near-bulldozer near-bulldozer bot merged commit a361b25 into master May 2, 2022
@near-bulldozer near-bulldozer bot deleted the nikurt-txpool-fix2 branch May 2, 2022 15:36
@nikurt nikurt mentioned this pull request May 3, 2022
Closed
nikurt added a commit that referenced this pull request May 18, 2022
@nikurt
Revert "Don't add transactions to a pool in non-validator nodes (#6713)"
9e7827c 
This reverts commit a361b25
nikurt added a commit that referenced this pull request May 18, 2022
@nikurt
Rollback #6713 due to the possibility of dropping transactions receiv…
8d3cdef 
…ed around an epoch boundary.
@mina86 mina86 mentioned this pull request May 18, 2022
Merged
near-bulldozer bot added a commit that referenced this pull request May 19, 2022
@nikurt @near-bulldozer
Rollback #6713 due to possibility of dropping transactions received r…
0b5b31b 
…ight before an epoch boundary. (#6827)

* Revert "Don't add transactions to a pool in non-validator nodes (#6713)"

This reverts commit a361b25

* Rollback #6713 due to the possibility of dropping transactions received around an epoch boundary.

* .

* TODO

Co-authored-by: near-bulldozer[bot] <73298989+near-bulldozer[bot]@users.noreply.github.com>
@aborg-dev aborg-dev mentioned this pull request Apr 24, 2023
Closed
aborg-dev added a commit to aborg-dev/nearcore that referenced this pull request Apr 24, 2023
@aborg-dev
Only store transactions on validator nodes
95e1d83 
At the moment transactions are indefinitely stored on RPC nodes that are
not validators (near#8878,
near#6713).

After this commit, such nodes will not store transactions in the
transaction pool at all.
@aborg-dev aborg-dev mentioned this pull request Apr 24, 2023
Merged
aborg-dev added a commit to aborg-dev/nearcore that referenced this pull request Apr 24, 2023
@aborg-dev
Only store transactions on validator nodes
b5a65b9 
At the moment transactions are indefinitely stored on RPC nodes that are
not validators (near#8878,
near#6713).

After this commit, such nodes will not store transactions in the
transaction pool at all.
aborg-dev added a commit to aborg-dev/nearcore that referenced this pull request Apr 24, 2023
@aborg-dev
Only store transactions on validator nodes
d397408 
At the moment transactions are indefinitely stored on RPC nodes that are
not validators (near#8878,
near#6713).

After this commit, such nodes will not store transactions in the
transaction pool at all.
aborg-dev added a commit to aborg-dev/nearcore that referenced this pull request Apr 24, 2023
@aborg-dev
Only store transactions on validator nodes
8a2bc47 
At the moment transactions are indefinitely stored on RPC nodes that are
not validators (near#8878,
near#6713).

After this commit, such nodes will not store transactions in the
transaction pool at all.
aborg-dev added a commit that referenced this pull request Apr 24, 2023
@aborg-dev
Only store transactions on validator nodes (#8965)
2da01b0 
At the moment transactions are indefinitely stored on RPC nodes that are not validators (#8878, #6713).

After this commit, nodes without validator keys will not store transactions in the transaction pool at all.
nikurt pushed a commit that referenced this pull request Apr 25, 2023
@aborg-dev @nikurt
Only store transactions on validator nodes (#8965)
591a256 
At the moment transactions are indefinitely stored on RPC nodes that are not validators (#8878, #6713).

After this commit, nodes without validator keys will not store transactions in the transaction pool at all.
nikurt pushed a commit that referenced this pull request Apr 28, 2023
@aborg-dev @nikurt
Only store transactions on validator nodes (#8965)
1b867e6 
At the moment transactions are indefinitely stored on RPC nodes that are not validators (#8878, #6713).

After this commit, nodes without validator keys will not store transactions in the transaction pool at all.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mm-near mm-near mm-near approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nikurt @mm-near