tests: Verify that transaction is valid and accepted #8976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aborg-dev
force-pushed
the
tp_use_process_tx
branch
from
71dca17
to
3600a2f
Compare
aborg-dev
added
A-congestion
aborg-dev
force-pushed
the
tp_use_process_tx
branch
from
3600a2f
to
98b4583
Compare
nikurt
approved these changes
Apr 26, 2023
aborg-dev
force-pushed
the
tp_use_process_tx
branch
from
98b4583
to
787e2f4
Compare
aborg-dev
force-pushed
the
tp_use_process_tx
branch
from
787e2f4
to
a55cb94
Compare
nikurt
pushed a commit
that referenced
this pull request
Apr 28, 2023
The result of `process_tx` is important because it tells whether the submitted transaction is valid and has been accepted. So we add `#[must_use]` annotation to it and fix all the tests that were not checking it. As a part of this, we fix two tests that were using incorrect nonce (but still somehow functioned...): - `benchmark_large_chunk_production_time` - `test_verify_chunk_invalid_state_challenge` This is a part of the work on introducing the transaction pool limits #8878.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The result of
process_txis important because it tells whether the submitted transaction is valid and has been accepted.So we add
#[must_use]annotation to it and fix all the tests that were not checking it.As a part of this, we fix two tests that were using incorrect nonce (but still somehow functioned...):
benchmark_large_chunk_production_timetest_verify_chunk_invalid_state_challengeThis is a part of the work on introducing the transaction pool limits #8878.