Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hardcoded shard number from prototype #382

Closed
Tracked by #8992
gabehamilton opened this issue Nov 11, 2023 · 3 comments · Fixed by #502
Closed
Tracked by #8992

Remove hardcoded shard number from prototype #382

gabehamilton opened this issue Nov 11, 2023 · 3 comments · Fixed by #502
Assignees

Comments

@gabehamilton
Copy link
Collaborator

In the initial prototype where S3 fetch time was a major impediment, number of shards was hardcoded to 4 in the runner.
https://github.com/near/queryapi/blob/main/runner/src/lake-client/lake-client.ts#L80

Now that we have some pre-fetching strategies let's return to pulling that from the block.json or move it to config.

@pkudinov
Copy link
Collaborator

pkudinov commented Nov 21, 2023

Duplicated by #423

@pkudinov pkudinov closed this as not planned Won't fix, can't repro, duplicate, stale Nov 21, 2023
@pkudinov pkudinov reopened this Nov 21, 2023
@gabehamilton
Copy link
Collaborator Author

Confirmed that the affected code was fixed in #423

@morgsmccauley
Copy link
Collaborator

This is still an issue:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants