Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add From First Seen Block option to Publish Indexer modal #923

Open
Tracked by #755
, #990
...
pkudinov opened this issue Jul 24, 2024 · 1 comment · May be fixed by #982
Open
Tracked by #755
, #990
...

Add From First Seen Block option to Publish Indexer modal #923

pkudinov opened this issue Jul 24, 2024 · 1 comment · May be fixed by #982
Assignees
@Kevin101Zhang

Comments

@pkudinov
Copy link
Collaborator

pkudinov commented Jul 24, 2024 •
edited
Loading

image

Add one more option "Start from first block XYZ", where XYZ can be taken from this query:

query MyQuery {
  dataplatform_near_receiver_blocks_bitmaps(
    limit: 1
    where: {receiver: {receiver: {_eq: "queryapi.dataplatform.near"}}}
    order_by: {block_date: asc}
  ) {
    first_block_height
  }
}
@pkudinov pkudinov mentioned this issue Jul 24, 2024
Open
@Kevin101Zhang Kevin101Zhang linked a pull request Aug 5, 2024 that will close this issue
feat propagate relevant data for first seen block in components #982
Draft
@Kevin101Zhang Kevin101Zhang mentioned this issue Aug 7, 2024
Open
@Kevin101Zhang
Copy link
Contributor

I'm having a bit of trouble understanding the necessity of this PR. From what I see, runner doesn't seem to be impacted whether we input the genesis block or the first seen block—the performance remains the same. This feature feels more like an attempt to demonstrate our knowledge of the user's contract filter, but we’ve already achieved that with the generated code based off select methods and events with the launchpad. Given this, I'm prioritizing editor-specific workflows that are impacted due to the launchpad, such as DiffView, context generation, and Monaco Editor types, over this feature.

wrap wizard with header code: #997
diff view: #999
type generation: #1001

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Kevin101Zhang Kevin101Zhang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat propagate relevant data for first seen block in components near/queryapi
2 participants
@pkudinov @Kevin101Zhang