Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v8.9.6 Release (dev -> main) #1087

Merged
merged 23 commits into from
Apr 3, 2024
Merged

v8.9.6 Release (dev -> main) #1087

merged 23 commits into from
Apr 3, 2024

Conversation

trechriron
Copy link
Collaborator

@trechriron trechriron commented Mar 27, 2024 •
edited
Loading

Description

Merge #1085 & #1077

Checklist:

  • [NA] I have performed a self-review of my own code
  • [NA] I have commented my code, particularly in hard-to-understand areas
  • [NA] I have made corresponding changes to the documentation
  • My changes generate no new warnings

Type of change.

  • FIX - a PR of this type patches a bug.
  • FEATURE - a PR of this type introduces a new feature.
  • BUILD - a PR of this type introduces build changes.
  • CI - a PR of this type introduces CI changes.
  • DOCS - a PR of this type introduces DOCS improvement.
  • STYLE - a PR of this type introduces style changes.
  • REFACTOR - a PR of this type introduces refactoring.
  • PERFORMANCE - a PR of this type introduces performance changes.
  • TEST - a PR of this type adds more tests.
  • CHORE - a PR introduces other changes than the specified above.

@trechriron trechriron self-assigned this Mar 27, 2024
@hcho112
Copy link
Contributor

hcho112 commented Mar 28, 2024

Please refer to this PR for convention to release a new package:
#1076

  1. Check its title, content
  2. Previously it is requested to bump ALL the package versions together. (Bumping up version is essential to get the packages automatically deployed to NPM)

@trechriron trechriron changed the title Merge Dev to Main for #1085 v8.9.6 Release (dev -> main) Mar 28, 2024
@trechriron
Copy link
Collaborator Author

Changed title.

@trechriron
Copy link
Collaborator Author

Need versions in json updated first. Will create new PR when ready.

@trechriron trechriron closed this Mar 28, 2024
@trechriron
Copy link
Collaborator Author

Will use this PR after fixing dev version bump.

@trechriron trechriron reopened this Mar 28, 2024
trechriron and others added 3 commits March 28, 2024 16:58
@trechriron trechriron requested a review from hcho112 April 1, 2024 23:16
@trechriron trechriron requested a review from andy-haynes April 1, 2024 23:16
hcho112
hcho112 previously approved these changes Apr 1, 2024
View reviewed changes
Copy link
Contributor

@hcho112 hcho112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@trechriron trechriron merged commit 0c558b4 into main Apr 3, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy-haynes andy-haynes andy-haynes approved these changes

@hcho112 hcho112 hcho112 left review comments

Assignees

@trechriron trechriron

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@trechriron @hcho112 @andy-haynes @AZbang @rubenmarcus @SurgeCode @microchipgnu @bowenwang1996