Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that test_summary.csv is up-to-date in CI #133

Open
Tracked by #172
aborg-dev opened this issue Dec 1, 2023 · 2 comments
Open
Tracked by #172

Check that test_summary.csv is up-to-date in CI #133

aborg-dev opened this issue Dec 1, 2023 · 2 comments

Comments

@aborg-dev
Copy link

Right now test_summary.csv is only updated when --update flag is set, but we don't verify that it is correct in the mode without an update.
I think at the very least, we should check in CI that this file is up-to-date.

@MCJOHN974
Copy link

Also, I think it would be great to have some github bot(?) which monitor PR changes and alaram us in PR discussion (simply posting message there) if any of state.csv is degradating in this PR. Maybe somebody knows some tools for it?

@aborg-dev
Copy link
Author

aborg-dev commented Jan 5, 2024

Also, I think it would be great to have some github bot(?) which monitor PR changes and alaram us in PR discussion (simply posting message there) if any of state.csv is degradating in this PR. Maybe somebody knows some tools for it?

I think that would be great - there is a GitHub Action that can create comments in PRs by the bot. For example, we can post testing and benchmarking results after each new commit in the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants