Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support different types of asserts in tests. #145

Closed
Tracked by #172
MCJOHN974 opened this issue Dec 5, 2023 · 2 comments
Closed
Tracked by #172

Support different types of asserts in tests. #145

MCJOHN974 opened this issue Dec 5, 2023 · 2 comments
Milestone
ZK WASM: Stage 2

Comments

@MCJOHN974
Copy link

Currently we have only one assert supported -- assert_eq. While we was working with arithmetics it was enough. But now, when we started work with memory operations, extends, etc, we need reacher set of asserts -- assert_fail, assert_trap, etc.
@aborg-dev aborg-dev added this to the ZK WASM: Stage 2 milestone Dec 11, 2023
@aborg-dev aborg-dev mentioned this issue Dec 11, 2023
Closed
@aborg-dev aborg-dev mentioned this issue Jan 2, 2024
Open
@MCJOHN974
Copy link
Author

Since assert_fail, assert_trap are irrelevant due to migration to filetests is #229 resolving it?

cc @Akashin

@aborg-dev
Copy link

Since assert_fail, assert_trap are irrelevant due to migration to filetests is #229 resolving it?

cc @Akashin

Yes, I think we can mark this as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
ZK WASM: Stage 2
Development

No branches or pull requests
2 participants
@aborg-dev @MCJOHN974