Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

housekeeping: developer cli #166

Closed
wants to merge 1 commit into from
Closed

housekeeping: developer cli #166

wants to merge 1 commit into from

Conversation

MCJOHN974
Copy link

Here I tried to gather all commands I frequently use in one place. Fixes #116

@MCJOHN974
Copy link
Author

MCJOHN974 commented Dec 19, 2023

Questions for reviewers:

  1. Does anybody know way to run only one zkasm file with verbose output?
  2. Does anybody know scenario when we locally compile without env UPDATE_EXPECT=1 ?
  3. Any other commands we want to see here?

@MCJOHN974
Copy link
Author

MCJOHN974 commented Dec 19, 2023

Also, using python make usage of script 8 key pressings longer, but I so love what python argparse do (it even generate -h automatically), comparing to bash, so...

@MCJOHN974 MCJOHN974 requested a review from mooori December 19, 2023 12:55
@mooori
Copy link

mooori commented Dec 20, 2023

Does anybody know way to run only one zkasm file with verbose output?

I haven’t tried it yet.

Does anybody know scenario when we locally compile without env UPDATE_EXPECT=1 ?

Possibly when doing a refactor which should not change generated zkASM.

Any other commands we want to see here?

Looks complete to me. Though keep in mind that I’m relatively new to working with this repo.

Copy link

@mooori mooori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be helpful, thanks @MCJOHN974! So far I’ve been keeping local Makefiles with commands I’m currently using. Having this cli instead provides a better dev experience.

LGTM overall. I didn’t write Python in a while, though, so can’t judge any Python specifics.

Copy link
Collaborator

@nagisa nagisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it not be a good idea to use the same tooling we use in nearcore (Justfile in particular) rather than writing our own python scripts for this (and even if we did not use just – why a python script over something less verbose like make ninja etc.?)

@MCJOHN974
Copy link
Author

Since we will significantly rework testing and benchmarking, this code no longer needed. But I think it will be nice to have such cli once changes in testing and benchmarking will land

@MCJOHN974 MCJOHN974 closed this Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make convinent developer CLI
3 participants