-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
housekeeping: developer cli #166
Conversation
Questions for reviewers:
|
Also, using python make usage of script 8 key pressings longer, but I so love what python argparse do (it even generate -h automatically), comparing to bash, so... |
I haven’t tried it yet.
Possibly when doing a refactor which should not change generated zkASM.
Looks complete to me. Though keep in mind that I’m relatively new to working with this repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be helpful, thanks @MCJOHN974! So far I’ve been keeping local Makefiles with commands I’m currently using. Having this cli instead provides a better dev experience.
LGTM overall. I didn’t write Python in a while, though, so can’t judge any Python specifics.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it not be a good idea to use the same tooling we use in nearcore (Justfile
in particular) rather than writing our own python scripts for this (and even if we did not use just
– why a python script over something less verbose like make ninja etc.?)
Since we will significantly rework testing and benchmarking, this code no longer needed. But I think it will be nice to have such cli once changes in testing and benchmarking will land |
Here I tried to gather all commands I frequently use in one place. Fixes #116