You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Having thought about this a little more and checked what the rest of the architectures in cranelift do, I believe we don’t actually want to go ham with wasm spec tests super early. One issue with them is that they are aimed at the runtime implementations (i.e. wasmtime) and thus require a good deal of surrounding runtime support to work at all.
On the other hand, cranelift maintains filetests like those that we've been adding with zkasm_data-based tests under filetests/filetests which I think we should port our current tests and add more tests.
If we need inspiration on what tests to add, we can compile interesting modules from the spec tests to clif and then add them to the filetests.
This should also be less up-front work and probably wouldn’t result in the effort being thrown away in case we ended upstreaming this.
Tasks
The text was updated successfully, but these errors were encountered: