Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tools to run Cranelift -> ZK ASM on WASM spec tests for Stage 1 #17

Closed
1 task done
Tracked by #23
aborg-dev opened this issue Sep 22, 2023 · 2 comments
Closed
1 task done
Tracked by #23

Tools to run Cranelift -> ZK ASM on WASM spec tests for Stage 1 #17

aborg-dev opened this issue Sep 22, 2023 · 2 comments
Assignees

Comments

@aborg-dev
Copy link

aborg-dev commented Sep 22, 2023

Tasks

Preview Give feedback
  1. MCJOHN974
@aborg-dev aborg-dev transferred this issue from near/nearcore Sep 26, 2023
@aborg-dev aborg-dev added this to the ZK WASM: Stage 1 milestone Sep 26, 2023
@nagisa
Copy link
Collaborator

nagisa commented Oct 25, 2023

Having thought about this a little more and checked what the rest of the architectures in cranelift do, I believe we don’t actually want to go ham with wasm spec tests super early. One issue with them is that they are aimed at the runtime implementations (i.e. wasmtime) and thus require a good deal of surrounding runtime support to work at all.

On the other hand, cranelift maintains filetests like those that we've been adding with zkasm_data-based tests under filetests/filetests which I think we should port our current tests and add more tests.

If we need inspiration on what tests to add, we can compile interesting modules from the spec tests to clif and then add them to the filetests.

This should also be less up-front work and probably wouldn’t result in the effort being thrown away in case we ended upstreaming this.

@aborg-dev
Copy link
Author

We have i32 and i64 spec tests imported now and we have infra to run them as a part of CI, so I'm making this as done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants