Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should we use handwritten tests? #189

Closed
MCJOHN974 opened this issue Jan 9, 2024 · 2 comments
Closed

Should we use handwritten tests? #189

MCJOHN974 opened this issue Jan 9, 2024 · 2 comments
Labels
zkasm-design Questions/Concerns/Issues with zkASM design

Comments

@MCJOHN974
Copy link

Currently, we have tests generated from wasm spectest, and some handwritten ones. Do we really want to keep the second?

Pros:

  • without handwritten ones test infrastructure will be simpler
    Cons:
  • maybe we will need some complicated tests not covered by spectest
@MCJOHN974 MCJOHN974 added the zkasm-design Questions/Concerns/Issues with zkASM design label Jan 9, 2024
@aborg-dev
Copy link

Given our recent discussions, I think the conclusion is that we want to use handwritten tests and we want to keep them as filetests written in CLIF. @MCJOHN974 Is there anything else to figure out here? If not, let's close this.

@MCJOHN974
Copy link
Author

Resolved by #215

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
zkasm-design Questions/Concerns/Issues with zkASM design
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aborg-dev @MCJOHN974