You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently zkasm_runner::ExecutionResult looks the following way:
pubstructExecutionResult{/// Path to the main zkAsm file that was executed.path:String,/// Status of the execution.pubstatus:ExecutionStatus,/// Error message in case the execution failed.puberror:Option<String>,/// Profiling information about this execution./// Only populated for the successful executions.counters:Option<Counters>,}
And I have a few questions about it:
is it true that if and only if status is ExecutionStatus::Success, than error contains None and counters contains Some?
is it true that if and only if status is ExecutionStatus::RuntimeError, than error contains Some and counters contains None?
If answer for both questions above is "yes" does we really need status field? It sounds like we already have info about status in error and counters fields. And, keeping one more such field will need to add extra attention to keep this fields consistent (be sure answer for both questions above is always "yes"). Maybe it will be better to remove this field and add method:
Or maybe even better will be to squash all this fields into just two:
pubstructExecutionResult{/// Path to the main zkAsm file that was executed.path:String,/// Contains profiling information in case of successful execution and error message/// if execution failedcounters:Result<Counters,String>}
Currently
zkasm_runner::ExecutionResult
looks the following way:And I have a few questions about it:
status
isExecutionStatus::Success
, thanerror
containsNone
andcounters
containsSome
?status
isExecutionStatus::RuntimeError
, thanerror
containsSome
andcounters
containsNone
?If answer for both questions above is "yes" does we really need
status
field? It sounds like we already have info about status inerror
andcounters
fields. And, keeping one more such field will need to add extra attention to keep this fields consistent (be sure answer for both questions above is always "yes"). Maybe it will be better to remove this field and add method:The text was updated successfully, but these errors were encountered: