Typed hits property in search method #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanieleFedeli
commented
Jul 17, 2022
| @@ -129,7 +135,7 @@ export class Lyra<TSchema extends PropertiesSchema = PropertiesSchema> { | |||
| break; | |||
| } | |||
|
|
|||
| const fullDoc = this.docs.get(id); | |||
| const fullDoc = this.docs.get(id)!; | |||
There was a problem hiding this comment.
@micheleriva Is there a better way to do that? I hate asserting non-null
There was a problem hiding this comment.
mmm afaik this is the only way... if there's a guarantee that the value exists, it's not that bad
micheleriva
approved these changes
Jul 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to avoid the assertion of a type when handling the result object.