Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #29.
The solution is to add, before the return statement, a filter by
Boolean
, so undefined elements are filtered.After doing several benchmarks between
filter
method,dynamic array
, and the current solution, the result makes the filter method more performant.Let me show you some data.
100K elements
Current fixed allocation array
Dynamic allocation array
Filtering results
1M elements
Dynamic allocation array
Filtering results
I also cleaned some variable names, (more readable in my opinion) by having them with the same name as the props returned in the function.